Bigass Commit, playtesting might be nice #1
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
abgit/UGJ128#1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Sooo this is a huge commit I feel like, I changed a lot of stuff but mainly related to the fishing minigame
Changelog :
Added fishing interface :
reeling bar, hitting point, fishing pole animation, caught fish texture and button to hide it and keep on fishin'Added Global variables for multipliers/attributes that will be changed by cards
Incorporated those variables in the fishes behaviors, fishing mini game and fish spawning.Added fishing line max length
When casting (doesnt cast)When reeling (checks for line HP and breaks if 0)Added a function in game interface and corresponding signal to play a sfx once
(UserInterface.playFxOneShot, takes string path of sfx as parameter)Better reset of hook :
Forgot to remove the coordinates from the GameGlobals.lurePosition before, so fishes would bite a non-existant hook after fishing had been cancelled or succeeded)Set GameGlobals.isHookFree to true and GameGlobals.lureValidAndCast = false when fishing ends or cancelled (fishes would not bite after fishing once).Reduce time between spawning/despawning fishes event
from 15 to 10 secondsMostly for debugging but would like your input on this time intervalIncrease probability of fish spawning
From 30 to 40% : I would find myself struggling to bait a fish as too much despawned and not enough spawnedRemove start menu settings panel and replace it with pause menu :
Volume sliders and labels would be inconsistent with pause menu ones, and this is the easiest way to fix : settings button now opens pause menu instead of a lookalikeUpdate fish texture sheet to be more consistent :
small fishes at the bottom and not spread throughout the sheetNow I think we need to playtest a lil bit to :
Bigass Commit, playtesting might be requiredto Bigass Commit, playtesting might be niceMy thoughts after playing four in-game days
reelingcasting distance is short but then it would feel great to expend it with updates. (Especially if valuable fishes tend to stay away from the dock)And I was wondering if you can fail to catch a fish?
But overall, it was a really pleasant experience. The music is really nice and it would be a cool chill game to play while listening to an audiobook.
XO XO
Gossip Girl
I'll update this comment as I go, striking text that is made no longer relevant by future commits :
@cahdmus wrote in #1 (comment):
--> Yes you can
but at the moment the only way is to full miss all your shots in a row, until the line gets too long and breaks, thus releasing the fishif the fish flees or you miss too muchBrain Dump
Bug
During the reeling minigame, I instinctively pressed Space.
I had clicked a button just before, so Space triggered the same button again and broke the minigame.
I think the pond scene should catch all input events and decide what to do with them itself. That would prevent weird interactions like this from happening.
Playtest
I'll add more notes here as I keep testing.
The reeling minigame feels awesome. A few ideas that seem pretty easy to implement and could tie into cards:
The fish could constantly try to escape at a certain speed. I think it would look better visually and add a bit more tension.
The last few pulls of the line can feel a little bit bad !
I agree with @cahdmus on the other topics.
For the reeling game you can just spam space and it will catch the fish no matter how well you do !
Same as with Cahdmus' comment, I'll update this one as we go
@fbouju wrote in #1 (comment):
@fbouju wrote in #1 (comment):
Since the fishes slowly flee away when you don't reel them in, a timer is kind of implied and tied to the fishing line length, you think it's good enough ?
Closing this for my OCD but I'll add the suggestions to issue #5